Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Fix type of sx prop in slotProps #37550

Merged
merged 5 commits into from
Jun 15, 2023
Merged

[Tooltip] Fix type of sx prop in slotProps #37550

merged 5 commits into from
Jun 15, 2023

Conversation

SuperKXT
Copy link
Contributor

@SuperKXT SuperKXT commented Jun 9, 2023 •
edited by ZeeshanTamboli

Fixes Tooltip's types to use the correct theme in slotProps for arrow and tooltip.

Before:
image

After:
image

Fixes #37236

@mui-bot
Copy link

mui-bot commented Jun 9, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37550--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 1bd1a48

@zannager zannager added the component: tooltip This is the name of the generic UI component, not the React module! label Jun 9, 2023
@zannager zannager requested a review from siriwatknp June 9, 2023 11:48
@ZeeshanTamboli ZeeshanTamboli changed the title Fix type of slotProps in Tooltip.d.ts [Tooltip] Fix type of sx prop in slotProps Jun 14, 2023
ZeeshanTamboli
ZeeshanTamboli approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I pushed a few changes.

@ZeeshanTamboli ZeeshanTamboli merged commit ab6dd2f into mui:master Jun 15, 2023
18 checks passed
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript package: material-ui Specific to @mui/material labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tooltip] Incorrect types for sx prop in slots
4 participants
@SuperKXT @mui-bot @ZeeshanTamboli @zannager