[material-ui] Replace the Album template with a landing page #37557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
design: material
9 tasks
Netlify deploy previewBundle size report |
zanivan
added
design
This comment was marked as outdated.
This comment was marked as outdated.
danilo-leal
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
DiegoAndai
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Overall looks good. I just have a tiny design feedback
I think we shouldn't add the theme switch in the layout, I would rather have it be a floating element on the bottom right and a toggle button instead of a switch.
I think that would make it easier to remove, and its use clearer.
docs/data/material/getting-started/templates/landing-page/components/AppAppBar.js
Show resolved
Hide resolved
siriwatknp
reviewed
Jan 31, 2024
docs/data/material/getting-started/templates/landing-page/getLPTheme.tsx
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Feb 1, 2024
Comment on lines
+66
to
+71
| ToggleCustomTheme.propTypes = { | ||
| showCustomTheme: PropTypes.shape({ | ||
| valueOf: PropTypes.func.isRequired, | ||
| }).isRequired, | ||
| toggleCustomTheme: PropTypes.func.isRequired, | ||
| }; |
There was a problem hiding this comment.
Should we remove the proptypes? It's not for everyone especially people who use TypeScript.
There was a problem hiding this comment.
It's from docs:typescript:formatted, isn't it? Also, this is in the js. file, users who use Typescript will use the .tsx file, won't they?
Anyway, I leave the decision to you @siriwatknp :)
siriwatknp
approved these changes
Feb 1, 2024
siriwatknp
force-pushed
the
template-polishing
branch
from
31afc63
to
11d46c7
Compare
zanivan
commented
Feb 1, 2024
docs/data/material/getting-started/templates/landing-page/getLPTheme.tsx
Show resolved
Hide resolved
danilo-leal
approved these changes
Feb 5, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Feb 6, 2024
Co-authored-by: Diego Andai <diego@mui.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37555
The idea is to transform the existing Album template into a Landing Page template. It's part of our initiative to review and enhance the free templates we offer.
👉 https://deploy-preview-37557--material-ui.netlify.app/material-ui/getting-started/templates/landing-page/