Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ButtonGroup][joy] Replace detached prop with spacing. #37562

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 10, 2023

This is not a breaking change because #37407 hasn't been released.

This PR replaces the detached prop with spacing prop which works better because it supports responsive values like Stack and Grid. It is more intuitive because setting spacing more than 0 will detach the buttons.

Screen.Recording.2566-06-11.at.00.40.50.mov

@siriwatknp siriwatknp added component: ButtonGroup The React component. package: joy-ui Specific to @mui/joy labels Jun 10, 2023
@mui-bot
Copy link

mui-bot commented Jun 10, 2023

Netlify deploy preview

@mui/joy: parsed: +0.24% , gzip: +0.13%

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 5a7e619

@siriwatknp siriwatknp merged commit fa4e314 into mui:master Jun 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ButtonGroup The React component. package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants