Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update roadmap page #37587

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jun 14, 2023

I noticed that the first result for the "Data Grid" search in Material UI links to the roadmap page which is a bit outdated:

I marked grid and pickers components as released and added links to their docs.
I also added links to components from the Lab for easier navigation.

Preview: https://deploy-preview-37587--material-ui.netlify.app/material-ui/discover-more/roadmap/#new-components

Before After

@cherniavskii cherniavskii added the website Pages that are not documentation-related, marketing-focused. label Jun 14, 2023
Comment on lines 56 to 57
| [Date Picker](/x/react-date-pickers/date-picker/) | MUI X | ✅ |
| [Date Range Picker](/x/react-date-pickers/date-range-picker/) | MUI X | ✅ |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to replace this with just "Date and Time Pickers", or link to more components from here instead.
cc @flaviendelangle

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know
On one hand we want to make very clear that we support advanced pickers, not just the usual DatePicker and TimePicker.
So not saying "range" at all on this page is a regression in clarity

But on the other hand, the current one totally lack the "time" part which is also important...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On one hand, it would make sense listing each picker components for better clarity:

  • Date Picker ✅
  • Time Picker ✅
  • Date Time Picker ✅
  • Date Range Picker ✅
  • Time Range Picker ⏳
  • Date Time Range Picker ⏳

This would allow for better visibility as to what is done and what do we still plan to do, but on the other hand, it does create a lot of noise... 🙈
Some other libraries do not even differentiate Range pickers in their docs, it's often just a different picker mode, thus

  • Date & Time Pickers ✅
  • Time & Date and Time Range Pickers ⏳
    could also work, albeit, with worse visibility 🙈

TL.DR. IMHO, we are not endorsing our components enough, hence, listing them here one by one does make sense, especially given the doc structure and components we expose. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of listing more picker components. How about fields?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I do agree that fields are a fundamental part of pickers, I'd say that in this context, it would probably make sense to omit them. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can focus on pickers 👍
Unless we have a use case by a component that is not also doable with a picker (if we release a duration component some say for instance).

@mui-bot
Copy link

mui-bot commented Jun 14, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 94f0425

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@cherniavskii cherniavskii merged commit e841af6 into mui:master Jun 19, 2023
18 checks passed
@cherniavskii cherniavskii deleted the update-roadmap branch June 19, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants