-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Inline the Base UI demo #37603
Merged
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Improvements or additions to the documentation
package: base-ui
Specific to @mui/base
labels
Jun 16, 2023
@@ -165,7 +165,7 @@ page](/material-ui/customization/theming/) to learn about theme customization. | |||
|
|||
## Why does component X require a DOM node in a prop instead of a ref object? | |||
|
|||
Components like the [Portal](/base-ui/api/portal/#props) or [Popper](/material-ui/api/popper/#props) require a DOM node in the `container` or `anchorEl` prop respectively. | |||
Components like the [Portal](/base-ui/react-portal/components-api/) or [Popper](/material-ui/api/popper/#props) require a DOM node in the `container` or `anchorEl` prop respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A 301
@@ -39,7 +39,7 @@ Please note that [react](https://www.npmjs.com/package/react) and [react-dom](ht | |||
|
|||
## Implementing a Button | |||
|
|||
This is a quick tutorial that goes through the basics of using and styling Base UI components by replicating a button from GitHub's UI, using their [Primer design system](https://primer.style) as a reference. | |||
This is a quick tutorial that goes through the basics of using and styling Base UI components by replicating a button from GitHub's UI, using their [Primer design system](https://primer.style/design/) as a reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A 301
oliviertassinari
force-pushed
the
base-ui-inline-demo
branch
2 times, most recently
from
June 16, 2023 00:39
def066f
to
acaa953
Compare
oliviertassinari
force-pushed
the
base-ui-inline-demo
branch
from
June 16, 2023 00:41
acaa953
to
a55a739
Compare
mj12albert
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
https://mui.com/base-ui/getting-started/quickstart/#styling-with-tailwind-css
After
https://deploy-preview-37603--material-ui.netlify.app/base-ui/getting-started/quickstart/#styling-with-tailwind-css