-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material] Rename custom tab panel in Tabs demo to prevent confusion with @mui/lab #37638
Conversation
Netlify deploy previewhttps://deploy-preview-37638--material-ui.netlify.app/ Bundle size report |
I ran all the tests mentioned in the contributing file. ✔️ Running
in
but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @MUK-Dev ! I'm not sure where those two extra files were coming from, but they don't exist on the master branch so I removed them and that solved the problem. :)
Ok, thanks |
This PR fixes #35466
On the Tabs docs page first example. A custom
TabPanel
was being declared and it used the same name as theTabPanel
in @mui/lab. So I renamed theTabPanel
in the local scope toCustomTabPanel
to avoid confusion and wrong auto imports.