[docs] Fix scrollbar on snackbar page #37657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
1 task
|
|
||
| export interface State extends SnackbarOrigin { | ||
| interface State extends SnackbarOrigin { |
There was a problem hiding this comment.
No need to export
| @@ -17,23 +17,18 @@ export default function PositionedSnackbar() { | |||
| const { vertical, horizontal, open } = state; | |||
|
|
|||
| const handleClick = (newState: SnackbarOrigin) => () => { | |||
| setState({ open: true, ...newState }); | |||
| setState({ ...newState, open: true }); | |||
There was a problem hiding this comment.
To be easier to scan, matching the code below
Comment on lines
28
to
30
| <React.Fragment> | ||
| <Grid container justifyContent="center"> | ||
| <Grid item> |
There was a problem hiding this comment.
Removed one <div>
Comment on lines
-48
to
-50
| </Grid> | ||
|
|
||
| <Grid container justifyContent="center"> |
There was a problem hiding this comment.
Code convention, no empty lines in JSX.
Netlify deploy previewhttps://deploy-preview-37657--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
docs-fix-snackbar-mobile
branch
from
e1f1bec
to
1ea900c
Compare
|
Perfect, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37389, I also worked one removing components in the demo to make it easier to process.
https://deploy-preview-37657--material-ui.netlify.app/material-ui/react-snackbar/#positioned-snackbars
https://deploy-preview-37657--material-ui.netlify.app/material-ui/react-snackbar/#control-slide-direction