-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Adjust demo component container design #37659
Conversation
Netlify deploy previewhttps://deploy-preview-37659--material-ui.netlify.app/ Bundle size report |
cc @alexfauquette & @siriwatknp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got confused because the difference between mui.com and the preview a more important than the code diff
Finally used a recent master deploy to do the comparison: https://deploy-preview-37675--material-ui.netlify.app/joy-ui/react-button/
On joy before/after: the border-radius on the top and the background image removed
About the radial-gradient modification, I assume it's impacting this kind of demonstration
@alexfauquette Got I a bit confused by your comment and just clarifying it before merging it 😅 Did you see anything that needs to be fixed? The deploy preview for this PR seems alright (i.e. intro Joy demo with rounded borders + no more tile background patterns). The radial gradients improvements can be fixed in another PR 🤙 |
It's good for me. I just took screen-shots if others wanted to see the before/after without having to browse docs example |
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This PR removes the tile-shaped background from the Material & Base intro demos and from Joy's common demos. It also adds the missing border radius for Joy's intro demo.