Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Adjust demo component container design #37659

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

danilo-leal
Copy link
Contributor

This PR removes the tile-shaped background from the Material & Base intro demos and from Joy's common demos. It also adds the missing border radius for Joy's intro demo.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product labels Jun 20, 2023
@mui-bot
Copy link

mui-bot commented Jun 20, 2023

Netlify deploy preview

https://deploy-preview-37659--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e152e67

@danilo-leal
Copy link
Contributor Author

cc @alexfauquette & @siriwatknp
Bumping this quick fix up so we can hopefully have it in the next release 😬

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused because the difference between mui.com and the preview a more important than the code diff

Finally used a recent master deploy to do the comparison: https://deploy-preview-37675--material-ui.netlify.app/joy-ui/react-button/

On joy before/after: the border-radius on the top and the background image removed
image

About the radial-gradient modification, I assume it's impacting this kind of demonstration

image

@danilo-leal
Copy link
Contributor Author

@alexfauquette Got I a bit confused by your comment and just clarifying it before merging it 😅 Did you see anything that needs to be fixed? The deploy preview for this PR seems alright (i.e. intro Joy demo with rounded borders + no more tile background patterns). The radial gradients improvements can be fixed in another PR 🤙

@alexfauquette
Copy link
Member

It's good for me. I just took screen-shots if others wanted to see the before/after without having to browse docs example

@danilo-leal danilo-leal self-assigned this Jun 23, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2023
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2023
@danilo-leal danilo-leal merged commit 17165b0 into master Jun 23, 2023
24 checks passed
@danilo-leal danilo-leal deleted the demo-component-design-adjustments branch June 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants