Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OutlinedInput] Fix form control properties in ownerState #37668

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[OutlinedInput] Fix form control properties in ownerState #37668

merged 1 commit into from
Jul 3, 2023

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Jun 21, 2023

Relevant lines in ownerState:

    color: fcs.color || 'primary',
    disabled: fcs.disabled,
    error: fcs.error,
    focused: fcs.focused,
    hiddenLabel: fcs.hiddenLabel,
    size: fcs.size,

Those properties will always be undefined on fcs unless they are listed in states.

@mui-bot
Copy link

mui-bot commented Jun 21, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37668--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against a8b267d

@zannager zannager added the component: FormControl The React component label Jun 22, 2023
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work regression A bug, but worse labels Jun 23, 2023
@michaldudak michaldudak removed the regression A bug, but worse label Jun 23, 2023
michaldudak
michaldudak approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix.

@michaldudak michaldudak merged commit e268fb0 into mui:master Jul 3, 2023
21 of 22 checks passed
@vonagam vonagam deleted the fix-outlined-input-owner-state branch July 3, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: FormControl The React component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vonagam @mui-bot @michaldudak @ZeeshanTamboli @zannager