Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notifications] Add notification for first Charts release #37679

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Jun 22, 2023

Summary

Notification inviting users to check out charts

image

@joserodolfofreitas joserodolfofreitas added the docs Improvements or additions to the documentation label Jun 22, 2023
@mui-bot
Copy link

mui-bot commented Jun 22, 2023

Netlify deploy preview

https://deploy-preview-37679--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 4742a89

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Though for latter, the banner could be replaced with the article about new features

image

docs/notifications.json Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though for latter, the banner could be replaced with the article about new features

Much agree, removed. I would be in favor of removing this slot altogether. It feels a bit like a strange tradeoff. If it's not really important, it can go in the notification panel, it's much better for devs to be able to free their space once seen. If it's more important, then it might be too easy to miss, it could be better as a top panel, like Vue has:

Screenshot 2023-06-23 at 20 19 08

https://vuejs.org/guide/essentials/application.html

HashiCorp has:

Screenshot 2023-06-23 at 20 20 34

https://developer.hashicorp.com/packer

cc @danilo-leal

docs/notifications.json Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@danilo-leal
Copy link
Contributor

re Banner: I like the idea of the top banner and I think we even have it developed already (we've used it for the v5 release if I recall correctly). Not to derail the PR too much but there's a trade-off I see for these components used to promote stuff: the top full-width banner will definitely be seen but exactly because it is aggressive to the navigation, should be removed faster, whereas the little callout that we have on the navbar can be less distracting but persist longer (this v6 one has been there for a while).

If we're keeping what we have right now, I think we should at least update it to mention the Charts instead! Maybe with a different emoji & color?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 24, 2023

the navbar can be less distracting but persist longer

The issue for me, on why it doesn't work (why I proposed to remove it) is that with the goal to display it longer, people will get accustomed to it, developing banner blindness for it. On the other hand, with the notification badge, it will only show if there is something new.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 25, 2023

Regarding the change itself, I'm not sure we would want to announce it in this format. There is cognitive dissonance for me to use the notification setting for something that isn't a blog post. Either 1. it's important, so it should be a blog post, or 2. it's not important, and so it shouldn't be a notification. We don't fit in 1 or 2, our case feels off.

By "blog post", I mean either https://mui.com/blog/ or an extended-release note like https://github.com/prisma/prisma/releases/tag/4.16.0, something that gives the audience a reason to be excited: explaining the problem, why this is needed, the solution is secondary. So I think either:

  • Quiet release path. We continue with the direction we started, we handle this as a silent early alpha release, to gather feedback before going to the audience. I mean, It looks like to me this is the direction we took since the changelog is more or less "empty" compared to what it could be. If it was on purpose, yeah, I see the merit, this could make sense if say we want to have a "MUI release week": 1st-day charts, 2nd-day Base UI, 3rd-day Figma plugin, 4th-day RSC support, 5th-day Joy UI release. Examples: https://supabase.com/launch-week, https://vercel.com/ship

  • Announcement path. In this path, I think that it's about turning https://github.com/mui/mui-x/releases/tag/v6.9.0 to be detailed or creating a blog post (better) to cover the problem, goal, why it's needed, roadmap (e.g. how do I know what will be paid). This is the real release.

    • Link it in the changelog
    • Tweet about it
    • Add a notification in the docs to point to it
    • Mention it in the newsletter
    • etc.

    Finally, hoping it will get amplified by the community, to have a real impact (otherwise the docs will likely have more impact). I think its where having more content significantly increases our chance to get this amplification.

@richbustos what was the release strategy of the charts?

Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@joserodolfofreitas joserodolfofreitas merged commit fc20c06 into mui:master Jul 14, 2023
18 checks passed
@joserodolfofreitas
Copy link
Member Author

joserodolfofreitas commented Jul 14, 2023

After discussing with @oliviertassinari, we agreed it's fine to release the notification to reach out to the core community.
It does deserve a blogpost, though. @alexfauquette is doing a technical blog about charts, and I'm showcasing charts
in a "v6 new features" blog post soon. @richbustos, glad to collaborate on it; please feel free to take over the PR, or hit me up on Slack, so we can talk about how you'd like to help.

@oliviertassinari
Copy link
Member

It sounds fair 👍

@deyvi-15

This comment was marked as off-topic.

@richbustos
Copy link
Contributor

@joserodolfofreitas would love to take over. I’m thinking video announcement and blog collab. Will slack you

@oliviertassinari
Copy link
Member

😁

Just noticed @MUI_hq quietly is releasing their React Charts. maybe not so quiet? but I just stumbled on 'em.

https://twitter.com/brianbehrens/status/1686133988434587648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants