Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Explain how to disable Base Select's portal #37684

Merged
merged 3 commits into from
Jun 28, 2023
Merged

[docs] Explain how to disable Base Select's portal #37684

merged 3 commits into from
Jun 28, 2023

Conversation

michaldudak
Copy link
Member

Adds the explanation about portals in Select.
Hopefully it'll help prevent issues like #37591

@michaldudak michaldudak added docs Improvements or additions to the documentation component: select This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Jun 23, 2023
@mui-bot
Copy link

mui-bot commented Jun 23, 2023 •
edited

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against f80767c

samuelsycamore
samuelsycamore approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple teeny tiny changes suggested (and it'd be fine without them) so I'll go ahead and preemptively approve it :)

docs/data/base/components/select/select.md Outdated Show resolved Hide resolved
michaldudak and others added 2 commits June 28, 2023 18:20
@michaldudak @samuelsycamore
Update docs/data/base/components/select/select.md
c2e3a02 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
@michaldudak @samuelsycamore
Update docs/data/base/components/select/select.md
f80767c 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
@michaldudak michaldudak merged commit 2458e39 into mui:master Jun 28, 2023
18 checks passed
@michaldudak michaldudak deleted the select-portal-docs branch June 28, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai6855 sai6855 sai6855 left review comments

@samuelsycamore samuelsycamore samuelsycamore approved these changes

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaldudak @mui-bot @sai6855 @samuelsycamore