Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Make Base UI button demos denser #37689

Merged
merged 14 commits into from
Jun 30, 2023
Merged

[docs][base] Make Base UI button demos denser #37689

merged 14 commits into from
Jun 30, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jun 23, 2023 •
edited by oliviertassinari

This PR basically makes the Base UI button demos a bit denser.

https://deploy-preview-37689--material-ui.netlify.app/base-ui/react-button/#introduction

@zanivan zanivan added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Jun 23, 2023
@mui-bot
Copy link

mui-bot commented Jun 23, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37689--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 1d4202e

@zanivan zanivan requested a review from danilo-leal June 23, 2023 19:57
@zanivan zanivan marked this pull request as ready for review June 23, 2023 20:03
@zanivan zanivan requested a review from mnajdova June 23, 2023 20:03
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer component: button This is the name of the generic UI component, not the React module! labels Jun 24, 2023
@zanivan zanivan mentioned this pull request Jun 27, 2023
Closed
13 tasks
@zanivan zanivan changed the title [docs][base] Design tweaks to Base UI button demos [docs][base] Make Base UI button demos denser Jun 27, 2023
danilo-leal
danilo-leal approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🤙

@zanivan zanivan merged commit 7338e10 into mui:master Jun 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zanivan @mui-bot @oliviertassinari @danilo-leal