[docs–infra] Prevent displaying multiple ads #37696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Comment on lines
20
to
21
| '& [id^=carbonads_]': { | ||
| display: 'none', | ||
| }, |
There was a problem hiding this comment.
The fix, it works because of this logic in the ad script:
var n = document.getElementsByClassName("carbon-wrap");
var fdiv = document.createElement("div");
fdiv.id = n.length > 0 ? "carbonads_" + n.length : "carbonads";
fdiv.appendChild(el);https://cdn.carbonads.com/carbon.js?serve=CKYIL27L&placement=material-uicom
oliviertassinari
force-pushed
the
ad-double-display
branch
from
c95ae86
to
1e468b4
Compare
Netlify deploy previewhttps://deploy-preview-37696--material-ui.netlify.app/ Bundle size report |
alexfauquette
approved these changes
Jun 26, 2023
Comment on lines
19
to
21
| '& [id^=carbonads_]': { | ||
| display: 'none', | ||
| }, |
There was a problem hiding this comment.
Suggested change
| '& [id^=carbonads_]': { | |
| display: 'none', | |
| }, | |
| '&>div': { | |
| display: 'none', | |
| }, |
Maybe more solid since it does not rely on how carbon manages its multiple ads
There was a problem hiding this comment.
Could also be based on
&>div: { display: 'hidden' },
&>div:last-of-type: { ... }There was a problem hiding this comment.
I have changed the approach, this should be more resilient, inspired by your comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://www.notion.so/mui-org/Trip-report-React-Summit-2023-18a3abdb83af4284b2d12f4deed18787?pvs=4#4554193ff13e46878e7f8b3e55db5d12, it was reported by a developer at React Summit, and something I experience every now and then too. Typically, it would look like this:
You can be reproduced easily by opening https://mui.com/material-ui/getting-started/overview/ and running
window._carbonads.init(). In real life, this happens because the script runs asynchronously, so if you have a slow connection, and quickly switch to a different page, you will see it.