-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Adjust demo container to be glued to the toolbar #37744
Conversation
Nice, I like it more than the live version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Netlify deploy previewhttps://deploy-preview-37744--material-ui.netlify.app/ Bundle size report |
@alexfauquette that's not as ideal because lots of these code blocks ⎯ if not all ⎯ are expandable by clicking on the |
there is only 2 buttons that so not affect the code (focus and reset) My main concern was that the toolbar is in between so it feel a bit weird since usually toolbar are at the top/bottom of what they control. But yes putting it at the bottom has also serious issues |
@alexfauquette gotcha. Either way, we could continue to reflect on this outside the scope of this PR 😬 |
I have pushed two commits to integrate #37693 into this PR. |
@alexfauquette & @oliviertassinari need an approval now if we're feeling good about it! 😬 |
Opening the PR to get a sense of how this feels. It's an exploration coming from @michaldudak's feedback that the code block feels disconnected now that the demo toolbar is part of the demo container itself. These changes make sense to me, but for some reason, I'm not 100% sure. Though definitely see how it can fly!
https://deploy-preview-37744--material-ui.netlify.app/joy-ui/react-button/#disabled