Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu][Joy] Improve UX of Menu usage demo #37797

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jul 3, 2023

Right now whenever user wants to test different variants of props for Menu they have open menu everytime and remember old version and current version to compare. I belive this process has lot of friction, so i kept Menu open all the time, so that user need not to open Menu everytime they want to try different variants of props.

before:

screen-recording-2023-07-03-at-100812-am_VRS4lu3P.mov

after:

screen-recording-2023-07-03-at-100243-am_3vCdvMtr.mov

@sai6855 sai6855 added docs Improvements or additions to the documentation component: menu This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jul 3, 2023
@sai6855 sai6855 requested a review from siriwatknp July 3, 2023 04:42
@mui-bot
Copy link

mui-bot commented Jul 3, 2023

Netlify deploy preview

https://deploy-preview-37797--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f7a990a

@siriwatknp
Copy link
Member

@sai6855 👍 Thanks for the improvement!

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, great improvement! 🎉

@danilo-leal danilo-leal merged commit c1c8683 into mui:master Jul 3, 2023
20 of 21 checks passed
@sai6855 sai6855 deleted the improve-menu-ux branch July 3, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants