[docs] Rename product to productId #37801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
regression
Netlify deploy previewhttps://deploy-preview-37801--material-ui.netlify.app/ Bundle size report |
oliviertassinari
approved these changes
Jul 3, 2023
| @@ -39,7 +39,7 @@ const createReactApp = (demo: { | |||
| raw: string; | |||
| codeVariant: CodeVariant; | |||
| githubLocation: string; | |||
| product?: Product; | |||
| productId?: Product; | |||
There was a problem hiding this comment.
We could almost change the type import, to use MuiProductId from getProductInfoFromUrl.ts
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #37729
When open a CodeSandbox from any Joy UI component, the
index.tsxuses@mui/material. Turns out it could not pick up the correct product identifier because the name of the variable changed in #37729.Before: open the code sandbox from https://deploy-preview-37729--material-ui.netlify.app/joy-ui/react-button/
Screen.Recording.2566-07-03.at.16.08.25.mov
After: try the deploy preview in this PR