Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing Portal elements to Tailwind CSS interoperability guide #37807

Merged

Conversation

enrique-ramirez
Copy link
Contributor

@enrique-ramirez enrique-ramirez commented Jul 4, 2023

Closes #36390

While implementing interoperability with Tailwind I was having issues with components inside my Dialog component. Turns out the guide is missing some Portal elements according to this comment. This PR adds the missing elements to the documentation so others don't waste time looking at this issue and wondering why it's not working.

@mui-bot
Copy link

mui-bot commented Jul 4, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against de51998

@zannager zannager added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! labels Jul 4, 2023
@zannager zannager requested a review from siriwatknp July 4, 2023 08:22
@mj12albert mj12albert changed the title [docs] Add missing Portal elements to interoperability guide [docs] Add missing Portal elements to Tailwind CSS interoperability guide Jul 6, 2023
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enrique-ramirez Thanks for working on this ~

@mj12albert mj12albert merged commit ab2cb8c into mui:master Jul 6, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully-installed Tailwind does not function inside of Dialog Component
4 participants