Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Fix code parser #37828

Merged
merged 3 commits into from
Jul 5, 2023
Merged

[docs-infra] Fix code parser #37828

merged 3 commits into from
Jul 5, 2023

Conversation

alexfauquette
Copy link
Member

For a reason I ignore, it was parsing the code already parsed 馃珷

Just updated marked to v5

@alexfauquette alexfauquette added regression A bug, but worse scope: docs-infra Specific to the docs-infra product labels Jul 5, 2023
@alexfauquette alexfauquette marked this pull request as ready for review July 5, 2023 12:39
michaldudak
michaldudak approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better :)

@mui-bot
Copy link

mui-bot commented Jul 5, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37828--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 馃毇 dangerJS against 372c06a

@alexfauquette alexfauquette merged commit 4bd5a21 into mui:master Jul 5, 2023
18 checks passed
@michaldudak
Copy link
Member

I've just noticed that yarn api:docs now spams the console with the following messages:

marked(): mangle parameter is enabled by default, but is deprecated since version 5.0.0, and will be removed in the future. To clear this warning, install https://www.npmjs.com/package/marked-mangle, or disable by setting `{mangle: false}`.
marked(): headerIds and headerPrefix parameters enabled by default, but are deprecated since version 5.0.0, and will be removed in the future. To clear this warning, install  https://www.npmjs.com/package/marked-gfm-heading-id, or disable by setting `{headerIds: false}`.

@alexfauquette alexfauquette mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfauquette @mui-bot @michaldudak