Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy] Revise the Joy UI Link page #37829

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jul 5, 2023

Part of #33998

This revision comes inspired by #37817 where I personally realized the different Link behavior when it comes to the variant prop. Made sure to document that and also included other standard sections/demos other components have.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: link This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jul 5, 2023
@danilo-leal danilo-leal self-assigned this Jul 5, 2023
@mui-bot
Copy link

mui-bot commented Jul 5, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 71e97bb

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvements all around!

docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
docs/data/joy/components/link/link.md Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor Author

@samuelsycamore let me know if this is good to go! 😬

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@danilo-leal danilo-leal merged commit 4efcd9c into master Jul 21, 2023
24 checks passed
@danilo-leal danilo-leal deleted the revise-joy-link-docs branch July 21, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: link This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants