Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Make Base UI Select demos denser #37836

Merged
merged 19 commits into from
Jul 11, 2023
Merged

[docs][base] Make Base UI Select demos denser #37836

merged 19 commits into from
Jul 11, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jul 5, 2023

This PR basically makes the Select demos a bit denser, and some minor consistency fixes on other components.

@zanivan zanivan added docs Improvements or additions to the documentation component: select This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: base-ui Specific to @mui/base labels Jul 5, 2023
@zanivan zanivan requested a review from danilo-leal July 5, 2023 19:39
@zanivan zanivan marked this pull request as ready for review July 5, 2023 19:39
@zanivan zanivan mentioned this pull request Jul 5, 2023
Closed
13 tasks
@mui-bot
Copy link

mui-bot commented Jul 5, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37836--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5fac631

@zanivan
Copy link
Contributor Author

zanivan commented Jul 6, 2023 •
edited

  • add box-shadow to selects just like the input

danilo-leal
danilo-leal approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🤙

@zanivan zanivan merged commit 51aced6 into mui:master Jul 11, 2023
18 checks passed
@mj12albert mj12albert mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zanivan @mui-bot @danilo-leal