Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add callouts about controlled vs uncontrolled components in Core docs #37849

Merged
merged 10 commits into from
Jul 7, 2023

Conversation

samuelsycamore
Copy link
Member

Users consistently express confusion about our usage of the terms "controlled" vs "uncontrolled"—many developers seem to be unaware of this React concept.

This has been resolved in the X docs by adding a callout everywhere it comes up to direct readers to the official React documentation on the topic. This PR does the same for the Core docs.

Screenshot 2023-07-06 at 1 50 28 PM

I think I caught all instances where the concept is mentioned. (I imagine the community will tell us soon enough if I missed any!)

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation support: docs-feedback Feedback from documentation page labels Jul 6, 2023
@samuelsycamore samuelsycamore marked this pull request as ready for review July 6, 2023 18:57
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, great addition! I'm sure this will help many people!

@samuelsycamore samuelsycamore merged commit b1d5889 into mui:master Jul 7, 2023
18 checks passed
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 15, 2023

I feel like #35352 could be a great use case for this. Similar to https://www.notion.so/help/synced-blocks.

@samuelsycamore samuelsycamore deleted the clarify-controlled branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation support: docs-feedback Feedback from documentation page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants