Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icons-material] Rebuild icons with "use client" #37894

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[icons-material] Rebuild icons with "use client" #37894

merged 2 commits into from
Jul 11, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jul 10, 2023 •
edited

Follow up to #37656

This PR rebuilds all the icons with "use client" prepended

Working demo: https://codesandbox.io/p/sandbox/condescending-matsumoto-xwtznj?file=%2Fapp%2Fpage.tsx%3A20%2C1

@mui-bot
Copy link

mui-bot commented Jul 10, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37894--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d18a26e

@mj12albert mj12albert mentioned this pull request Jul 10, 2023
Merged
1 task
@mnajdova mnajdova added package: icons Specific to @mui/icons core Infrastructure work going on behind the scenes labels Jul 10, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 10, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 11, 2023
@mj12albert mj12albert marked this pull request as ready for review July 11, 2023 07:28
@mj12albert mj12albert marked this pull request as draft July 11, 2023 08:02
@mj12albert mj12albert mentioned this pull request Jul 11, 2023
Merged
1 task
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 11, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 11, 2023
@mj12albert mj12albert marked this pull request as ready for review July 11, 2023 10:52
@mj12albert mj12albert requested review from siriwatknp and a team July 11, 2023 10:54
siriwatknp
siriwatknp approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked only the first file.

michaldudak
michaldudak approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demos work fine and the built icons have the directive. LGTM.

@mj12albert
Copy link
Member Author

Thanks for checking 🙏

@mj12albert mj12albert merged commit 2d6a55a into mui:master Jul 11, 2023
18 checks passed
@mj12albert mj12albert deleted the icons-prepend-use-client branch July 11, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mj12albert @mui-bot @michaldudak @siriwatknp @mnajdova