[Menu][material] Fixes slots and slotProps overriding defaults completely #37902
+108
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-37902--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
changed the title
danilo-leal
added
component: menu
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
@DiegoAndai this PR is ready for review |
DiegoAndai
requested changes
Jul 14, 2023
There was a problem hiding this comment.
Hey @gitstart thanks for working on this!
I left a couple comments that should be fixed 😊
Besides that, we should also add tests to cover the cases this PR fixes
Let me know if you need any help
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
Your feedback has been implemented @DiegoAndai, thanks for the review. |
github-actions
bot
added
the
PR: out-of-date
DiegoAndai
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Hey @gitstart! thanks for implementing the feedback, here are a few more comments so we can continue forward with this PR
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
Your comments have been addressed @DiegoAndai, thanks for the feedback. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
slots&slotPropsoverriding defaultsslots&slotPropson Menu componentsCloses #37612
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.