Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Add Tailwind CSS & plain CSS demo on the form control page #37914

Merged
merged 6 commits into from
Jul 12, 2023
Merged

[docs][base] Add Tailwind CSS & plain CSS demo on the form control page #37914

merged 6 commits into from
Jul 12, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base component: FormControl The React component labels Jul 11, 2023
@mui-bot
Copy link

mui-bot commented Jul 11, 2023 •
edited

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 71ee6d1

@mnajdova mnajdova marked this pull request as ready for review July 11, 2023 09:40
@mnajdova mnajdova requested a review from zanivan July 11, 2023 09:41
@mnajdova mnajdova mentioned this pull request Jul 11, 2023
Closed
17 tasks
@zanivan
Copy link
Contributor

zanivan commented Jul 11, 2023

I tweaked the demos a bit, just fine-tuning to look more like the other ones--but it was looking good already.

One thing, though, is that I'm getting this error:

Unhandled Runtime Error
ReferenceError: StyledInput is not defined

Is there anything to do with the placeholder text that I've added?

@mnajdova
Copy link
Member Author

Unhandled Runtime Error
ReferenceError: StyledInput is not defined

I can't reproduce, all styling solutions with a combination of JavaScript and TypeScript work for me. Maybe it happened before you run yarn docs:typescript:formatted?

zanivan
zanivan approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it happened before you run yarn docs:typescript:formatted?

Yep, might be it. It works just fine now. 👍

@mnajdova mnajdova merged commit 47790b6 into mui:master Jul 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

Assignees
No one assigned
Labels
component: FormControl The React component docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnajdova @mui-bot @zanivan