Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update installation commands to use the new tabs code component #37927

Merged
merged 6 commits into from
Jul 13, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jul 11, 2023

This PR updates installation commands with the new HighlightedCodeWithTabs component, adding tabs to the code blocks. Picking up from a fantastic work by @alexfauquette on the component; here, I've refined the styles & updated the Core libraries docs.

https://deploy-preview-37927--material-ui.netlify.app/material-ui/getting-started/installation/

Before After
Screen Shot 2023-07-11 at 15 11 52 Screen Shot 2023-07-11 at 15 12 04

@danilo-leal danilo-leal added docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product labels Jul 11, 2023
@danilo-leal danilo-leal requested review from samuelsycamore and a team July 11, 2023 17:59
@danilo-leal danilo-leal self-assigned this Jul 11, 2023
@danilo-leal
Copy link
Contributor Author

@alexfauquette Would you know why, upon entering a new page, sometimes the blocks look separated? After a refresh, it gets fixed but it definitely looks like some bug 🤔

Screen Shot 2023-07-12 at 15 02 22

@samuelsycamore
Copy link
Member

Love it! The Material Icons and About the lab pages could use these too. There may be a few other random pages here and there as well.

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up :)

@danilo-leal
Copy link
Contributor Author

@alexfauquette Awesome! I'll be merging this one now but we might want to take a look at why #37927 (comment) is happening 😬

@danilo-leal danilo-leal merged commit bc35128 into master Jul 13, 2023
24 checks passed
@danilo-leal danilo-leal deleted the refine-highlightedcode-with-tabs branch July 13, 2023 12:21
@alexfauquette
Copy link
Member

@danilo-leal I do not manage to reproduce the bug. Could you open an issue for it with docs-infra label such that we can keep it in mind to solve it when we've time.

@oliviertassinari oliviertassinari changed the title [docs-infra] Update installation commands to use the new tabs code component [docs] Update installation commands to use the new tabs code component Jul 13, 2023
@oliviertassinari oliviertassinari removed the scope: docs-infra Specific to the docs-infra product label Jul 13, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 13, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants