Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Add MuiMenuList to createTheme components key #37956

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[Menu] Add MuiMenuList to createTheme components key #37956

merged 1 commit into from
Jul 17, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jul 14, 2023 •
edited

Fixes #37949

The fix allows this to work without a TS error:

const theme = createTheme({
  components: {
    MuiMenuList: {
      defaultProps: {
        dense: true,
      },
    },
  },
});

Sandbox: https://codesandbox.io/s/https-github-com-mui-material-ui-pull-37956-st5yhg?file=/src/index.tsx:221-351

@mj12albert mj12albert added component: menu This is the name of the generic UI component, not the React module! typescript package: material-ui Specific to @mui/material labels Jul 14, 2023
@mui-bot
Copy link

mui-bot commented Jul 14, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37956--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 78b73c8

@mj12albert mj12albert marked this pull request as ready for review July 14, 2023 07:56
@mj12albert mj12albert requested review from mnajdova and a team July 14, 2023 07:56
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Jul 14, 2023
@mj12albert mj12albert merged commit dd4c199 into mui:master Jul 17, 2023
21 of 22 checks passed
@mj12albert mj12albert deleted the 37949-createtheme-component-type-definitions-are-missing-muimenulist branch July 27, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu] createTheme component type definitions are missing MuiMenuList
4 participants
@mj12albert @mui-bot @DiegoAndai @ZeeshanTamboli