[website] Fix a11y issues #37999
Merged
[website] Fix a11y issues #37999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
accessibility
Netlify deploy previewhttps://deploy-preview-37999--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
fix-menu-a11y
branch
from
9f16247
to
efd3fdf
Compare
Comment on lines
41
to
+43
| id="mui-product-selector" | ||
| aria-controls="drawer-open-button" | ||
| aria-haspopup="true" | ||
| aria-controls={open ? 'drawer-open-button' : undefined} |
Comment on lines
-38
to
+65
| ref={rightRef} | ||
| id="hero-container-right-area" | ||
| ref={frame} |
Comment on lines
-257
to
+227
| <ul ref={navRef} role="menubar" onKeyDown={handleLeftRightArrow}> | ||
| <ul ref={navRef} onKeyDown={handleKeyDown}> |
There was a problem hiding this comment.
Fix
Per https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/,
it makes more sense to me to use the disclosure pattern as our menu will likely grow to be more complex than what menubar support, this is also what Stripe and Radix did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #37997