Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix the empty /components page #38010

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

brijeshb42
Copy link
Contributor

Fixes #38008

Since top level /components/ doesn't have any productId, I am using material-ui's pages to list all the components. Maybe we can provide a Select component to change the listing and also add the productId to the url param.

@mui-bot
Copy link

mui-bot commented Jul 17, 2023

Netlify deploy preview

https://deploy-preview-38010--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 23d924e

@brijeshb42 brijeshb42 added the docs Improvements or additions to the documentation label Jul 17, 2023
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! In the future, we can definitely revamp this page so it displays components from the other products as well, aside from just Material UI 🤙

@brijeshb42 brijeshb42 merged commit 1f41932 into mui:master Jul 17, 2023
18 of 19 checks passed
@brijeshb42 brijeshb42 deleted the docs-fix-components-page branch July 17, 2023 14:30
@oliviertassinari oliviertassinari changed the title [docs]: Fix the empty /components page [docs] Fix the empty /components page Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

[docs] All components docs page is empty
3 participants