Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skeleton][joy] Fix WebkitMaskImage CSS property #38077

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[Skeleton][joy] Fix WebkitMaskImage CSS property #38077

merged 1 commit into from
Jul 21, 2023

Conversation

Bestwebdesign
Copy link
Contributor

@Bestwebdesign Bestwebdesign commented Jul 20, 2023 •
edited by oliviertassinari

closes #38051

Fixes the error displayed in the console reported in #38051

Using kebab-case for css properties in objects is not supported. Did you mean WebkitMaskImage?
in JoySkeletonRoot (created by Skeleton)
in Skeleton (created by InlineSkeleton)
in InlineSkeleton

https://deploy-preview-38077--material-ui.netlify.app/joy-ui/react-skeleton/

@mui-bot
Copy link

mui-bot commented Jul 20, 2023 •
edited

Netlify deploy preview

https://deploy-preview-38077--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7ca005a

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: skeleton This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jul 21, 2023
@zannager zannager requested a review from siriwatknp July 21, 2023 05:09
siriwatknp
siriwatknp approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the fix and welcome to the community 🍾

@siriwatknp siriwatknp merged commit 2974bfe into mui:master Jul 21, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: skeleton This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Skeleton][joy-ui] Long text is partially visible in Firefox
4 participants
@Bestwebdesign @mui-bot @siriwatknp @oliviertassinari