[examples] Fix Joy UI Next.js App Router font loading #38095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38095--material-ui.netlify.app/ Bundle size report |
mwskwong
reviewed
Jul 21, 2023
oliviertassinari
added
examples
oliviertassinari
changed the title
|
I have pushed a commit to normalize all the Next.js font loading. Off-topic. The content of the pages for the Joy UI and Material UI examples don't really make sense for me, those are starters, so I think they should point to the templates page but not include any. |
2 tasks
Thanks ~ looks neater to do this in the |
mj12albert
approved these changes
Jul 24, 2023
| <FormLabel>Email</FormLabel> | ||
| <Input name="email" type="email" placeholder="johndoe@email.com" /> | ||
| </FormControl> | ||
| <FormControl> | ||
| <FormControl id="password"> |
There was a problem hiding this comment.
Fix related to this problem #38103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to align all the used font-family styles of MUI components when next/font is used.
Similar to this PR: #38026
Before
After
Close #38083