[Autocomplete][material][joy] Add default getOptionLabel prop in ownerState
#38100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38100--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
|
@ZeeshanTamboli I couldn't add labels here. Check is failing. |
mj12albert
added
the
component: autocomplete
…tionLalebl-in-renderOption
mj12albert
reviewed
Jul 24, 2023
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
getOptionLabel prop in ownerState
ZeeshanTamboli
changed the title
getOptionLabel prop in ownerStategetOptionLabel prop in ownerState
ZeeshanTamboli
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
I made the remaining changes.
@DSK9012 Thanks for the pull request! It's a great first PR at MUI!
Hey, Thanks for that Zeeshan. It's an honour to contribute to MUI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38048
Default
getOptionLabelcan now accessed in ownerState If not provided as custom prop.