[core] Fix rsc-builder removing the first line #38134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of RSC builder would remove the first line of the file and add
'use client'
instead of it. With this change, it now checks if the file contains the directive in its first line and skips processing if it does.I also improved EOL handling. Since our
.gitattributes
explicitly specifieseol=lf
, we don't need to handle CRLF in sources, even on Windows.