[Theme][material] Add missing styleOverrides type for theme MuiStack #38189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
customization: theme
Netlify deploy previewhttps://deploy-preview-38189--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
This is indeed implemented https://codesandbox.io/s/gallant-star-hv895x?file=/src/App.tsx. I left this feedback in #28843 (comment) 😁
|
@oliviertassinari yes 😊, it was only missing the type so TS was throwing an error This is the same codesandbox but using this PR's material build: https://codesandbox.io/s/romantic-dewdney-mgscff?file=/src/App.tsx. |
DiegoAndai
changed the title
oliviertassinari
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #38151
The
styleOverridesMuiStackkey type was missing from the overridesComponentstype: #28843 (comment)