Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix palette pages - live edit not working #38195

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 27, 2023

Preview: https://deploy-preview-38195--material-ui.netlify.app/material-ui/customization/palette/

A quick follow-up on #37743, this is a great step forward (will change with MD3) but I was so confused coming from https://twitter.com/DiegoAndaiC/status/1683865879677739008 and trying to edit the demos with no effect:

Screen.Recording.2023-07-28.at.00.57.36.mov

I did side fixes at the same time:

  1. I have added a note in the a11y section for https://mui.com/material-ui/customization/palette/#contrast-threshold
Screenshot 2023-07-28 at 00 56 37

contrastThreshold makes the color contrast much worse in this case: https://contrast.tools/?tab=apca&text=ffffff&background=ed6d03 vs. https://contrast.tools/?tab=apca&text=1C2026&background=ed6d03.

  1. I fixed the ad link color. "Get started" is barely visible.
Screenshot 2023-07-28 at 01 00 44
  1. I fixed the scrollbar on mobile https://mui.com/material-ui/customization/palette/
Screenshot 2023-07-28 at 01 05 54

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Jul 27, 2023
@oliviertassinari oliviertassinari changed the title [docs] Fix live edit not working [docs] Fix palette pages - live edit not working Jul 27, 2023
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and jumping on it @oliviertassinari 😊

I agree with the changes, just have a couple of minor questions.

A general comment is that I didn't know about live editing since a couple of weeks ago when I saw you use it 😅 Maybe we could change the tooltip from "Show source code" to "Show live example"? 🤔

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 28, 2023

A general comment is that I didn't know about live editing since a couple of weeks ago when I saw you use it 😅 Maybe we could change the tooltip from "Show source code" to "Show live example"? 🤔

I think "Show source code" is still what most people want to use this expand button for. So while the live example is new, I think we would need to find another affordance path.

@DiegoAndai
Copy link
Member

@oliviertassinari true, maybe there's another way we can make it more noticeable that the code is editable

@oliviertassinari oliviertassinari merged commit c606154 into mui:master Jul 28, 2023
18 checks passed
@oliviertassinari oliviertassinari deleted the fix-live-edit branch July 28, 2023 18:43
@oliviertassinari
Copy link
Member Author

React Bootstrap shows some sort of a popup, could be an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants