-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix palette pages - live edit not working #38195
Conversation
784ed2b
to
a9005cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and jumping on it @oliviertassinari 😊
I agree with the changes, just have a couple of minor questions.
A general comment is that I didn't know about live editing since a couple of weeks ago when I saw you use it 😅 Maybe we could change the tooltip from "Show source code"
to "Show live example"
? 🤔
I think "Show source code" is still what most people want to use this expand button for. So while the live example is new, I think we would need to find another affordance path. |
@oliviertassinari true, maybe there's another way we can make it more noticeable that the code is editable |
React Bootstrap shows some sort of a popup, could be an idea. |
Preview: https://deploy-preview-38195--material-ui.netlify.app/material-ui/customization/palette/
A quick follow-up on #37743, this is a great step forward (will change with MD3) but I was so confused coming from https://twitter.com/DiegoAndaiC/status/1683865879677739008 and trying to edit the demos with no effect:
Screen.Recording.2023-07-28.at.00.57.36.mov
I did side fixes at the same time:
contrastThreshold
makes the color contrast much worse in this case: https://contrast.tools/?tab=apca&text=ffffff&background=ed6d03 vs. https://contrast.tools/?tab=apca&text=1C2026&background=ed6d03.