-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Polish API page design #38196
Merged
danilo-leal
merged 10 commits into
mui:master
from
oliviertassinari:improve-design-api-pages
Jul 31, 2023
Merged
[docs-infra] Polish API page design #38196
danilo-leal
merged 10 commits into
mui:master
from
oliviertassinari:improve-design-api-pages
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
design
This is about UI or UX design, please involve a designer
scope: docs-infra
Specific to the docs-infra product
labels
Jul 27, 2023
oliviertassinari
force-pushed
the
improve-design-api-pages
branch
from
July 27, 2023 23:39
4f19064
to
dd7fdb2
Compare
Netlify deploy previewhttps://deploy-preview-38196--material-ui.netlify.app/ Bundle size report |
alexfauquette
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me but maybe @danilo-leal will have a better opinion
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 31, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 31, 2023
danilo-leal
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexfauquette
added a commit
to cherniavskii/material-ui
that referenced
this pull request
Aug 1, 2023
richbustos
pushed a commit
that referenced
this pull request
Aug 4, 2023
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
This is about UI or UX design, please involve a designer
scope: docs-infra
Specific to the docs-infra product
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-38196--material-ui.netlify.app/material-ui/api/alert/#props
An iteration on #37405 after the feedback in https://twitter.com/MUI_hq/status/1683914002332635137.
To help with https://twitter.com/goose_plus_plus/status/1683915602425962504 from @dmtrKovalenko, I have:
To help with https://twitter.com/StylesTrip/status/1683927012791193601, I have:
But I think that #38173 will do the reset.