Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Sync team member with HiBob, add Raffaella #38201

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

rluzists1
Copy link
Contributor

@rluzists1 rluzists1 commented Jul 28, 2023

Raffaella Luzi about me
@mui-bot
Copy link

mui-bot commented Jul 28, 2023

Netlify deploy preview

https://deploy-preview-38201--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 35742e2

@mj12albert mj12albert added the website Pages that are not documentation-related, marketing-focused. label Jul 28, 2023
@oliviertassinari oliviertassinari changed the title About Me [website] Sync team member with HiBob, add Raffaella Jul 28, 2023
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rluzists1 Nice! There isn't much that could have been done better.

One detail: we try to work with forks as much as possible

Screenshot 2023-07-28 at 18 31 12

While I was at it, I explored a bit more:

curl 'https://tools-public.mui.com/prod/api/data/muicomabout/queryAbout' \
  -H 'content-type: application/json' \
  --data-raw '{}' \
  --compressed

@oliviertassinari oliviertassinari merged commit a85f534 into master Jul 28, 2023
24 checks passed
@oliviertassinari oliviertassinari deleted the raffaellaaboutme branch July 28, 2023 16:44
@Janpot
Copy link
Member

Janpot commented Aug 1, 2023

  • We need to have a proxy API call for data permission, @Janpot I thought that I could maybe use Toolpad for this, just bind a function with no UI, only to fetch. I could set up an express server but I'm lazy

We're currently not treating these rest data endpoints as public API. If you start calling them this way, we're going to have to make sure they remain stable across versions.
If we start supporting using Toolpad as an API gateway to its backend functions, I think it the best would be to make that explicit. e.g. have users explicitly configure routes that call backend functions.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2023

We're currently not treating these rest data endpoints as public API. If you start calling them this way, we're going to have to make sure they remain stable across versions.

@Janpot Feel free to break these API calls, I'm hacking around. But it's interesting to see this unintended value of Toolpad, to be able to quickly host backend code 😁.

I guess we start to need to have a proper backend. We have a few AWS lambda with claudia.js but the DX feels like hell.

In any case, I don't plan to push HiBob introduction with the about page much further. Today, it's not worth the opportunity cost for me to solve https://www.notion.so/mui-org/Sync-mui-com-about-page-with-HiBob-ba1ac2819df44b97b02a41a2d9b40ed0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants