-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Sync team member with HiBob, add Raffaella #38201
Conversation
Netlify deploy previewhttps://deploy-preview-38201--material-ui.netlify.app/ Bundle size report |
e805e45
to
35742e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rluzists1 Nice! There isn't much that could have been done better.
One detail: we try to work with forks as much as possible
While I was at it, I explored a bit more:
- For @mnajdova and @DanailH I have updated the about page to reflect the offboarding.
- I have explored a bit the feasibility of using HiBob API to feed in all this data. This seems to work: https://tools-public.mui.com/prod/pages/nSwYn51. Greg will move all the data to HiBob with https://www.notion.so/Migrate-Short-note-to-HiBob-2b548b580d834d6d9481e4fb60f30e97. Next, we could create a script to run that would update this .json automatically. But I'm too lazy for this. What I was more curious about is if we could use HiBob API :).
- We need to have a proxy API call for data permission, @Janpot I thought that I could maybe use Toolpad for this, just bind a function with no UI, only to fetch. I could set up an express server but I'm lazy
curl 'https://tools-public.mui.com/prod/api/data/muicomabout/queryAbout' \
-H 'content-type: application/json' \
--data-raw '{}' \
--compressed
We're currently not treating these rest data endpoints as public API. If you start calling them this way, we're going to have to make sure they remain stable across versions. |
@Janpot Feel free to break these API calls, I'm hacking around. But it's interesting to see this unintended value of Toolpad, to be able to quickly host backend code 😁. I guess we start to need to have a proper backend. We have a few AWS lambda with claudia.js but the DX feels like hell. In any case, I don't plan to push HiBob introduction with the about page much further. Today, it's not worth the opportunity cost for me to solve https://www.notion.so/mui-org/Sync-mui-com-about-page-with-HiBob-ba1ac2819df44b97b02a41a2d9b40ed0. |
Preview: https://deploy-preview-38201--material-ui.netlify.app/about/