Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unnecessary Required utility type from Typography font style type #38203

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jul 28, 2023

All of the FontStyle type's properties are already required, so using the Required utility type is unnecessary. This was noticed while working on #38123.

@ZeeshanTamboli ZeeshanTamboli added typescript component: Typography The React component. core Infrastructure work going on behind the scenes labels Jul 28, 2023
@mui-bot
Copy link

mui-bot commented Jul 28, 2023

Netlify deploy preview

https://deploy-preview-38203--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7a22c3f

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review July 28, 2023 17:00
@oliviertassinari oliviertassinari added package: material-ui Specific to @mui/material component: Typography The React component. and removed component: Typography The React component. labels Jul 28, 2023
@oliviertassinari
Copy link
Member

Nice catch, trivial change 👍

@ZeeshanTamboli ZeeshanTamboli merged commit 9dc13d3 into mui:master Jul 29, 2023
24 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the fix-typography-font-style-type branch July 29, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Typography The React component. core Infrastructure work going on behind the scenes package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants