[Skeleton] Make the demos feel more realistic #38212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
joy-skeleton-realistic-demo
branch
2 times, most recently
from
d6b29b3
to
88c9b7b
Compare
Comment on lines
-29
to
+34
| {loading ? 'Stop' : 'Start'} Loading | ||
| {loading ? 'Stop' : 'Start'} loading |
There was a problem hiding this comment.
Casing convention.
| <Box sx={{ display: 'flex', gap: 2 }}> | ||
| <Stack spacing={2} useFlexGap> |
| src="https://images.unsplash.com/photo-1686548812883-9d3777f4c137?h=400&fit=crop&auto=format&dpr=2" | ||
| src="data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs=" |
There was a problem hiding this comment.
We are not supposed to have the real data at this point in time.
| <Box sx={{ m: 'auto', display: 'flex', alignItems: 'center', gap: 2 }}> | ||
| <Skeleton loading={loading} variant="circular" width={48} height={48} /> | ||
| <Box> |
There was a problem hiding this comment.
Empty boxes like this one looks wrong, I'm expanding the thought on this in mui/mui-x#9831.
Comment on lines
-1
to
7
| <Box sx={{ m: 'auto' }}> | ||
| <Avatar src={loading ? '' : '/static/images/avatar/1.jpg'}> | ||
| <Skeleton loading={loading} /> | ||
| </Avatar> | ||
| </Box> | ||
| <FormControl | ||
| orientation="horizontal" | ||
| sx={{ gap: 1, justifyContent: 'center' }} | ||
| > | ||
| <Avatar src={loading ? '' : '/static/images/avatar/1.jpg'}> | ||
| <Skeleton loading={loading} /> | ||
| </Avatar> | ||
| <FormControl orientation="horizontal" sx={{ gap: 1 }}> | ||
| <Switch | ||
| size="sm" | ||
| checked={loading} |
There was a problem hiding this comment.
Simpler preview
oliviertassinari
force-pushed
the
joy-skeleton-realistic-demo
branch
from
88c9b7b
to
df9b497
Compare
Netlify deploy previewhttps://deploy-preview-38212--material-ui.netlify.app/ Bundle size report |
zanivan
approved these changes
Aug 1, 2023
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
Co-authored-by: zanivan <victorzanivan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #37893 (comment). My goal is to make the examples more realistic as well as simpler. It's a quick polish.
Before: https://mui.com/joy-ui/react-skeleton/
After: https://deploy-preview-38212--material-ui.netlify.app/joy-ui/react-skeleton/