Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy] Update the TypeScript file to match the styles in the corresponding JavaScript file for adding more typography levels demo #38232

Merged
merged 2 commits into from
Jul 30, 2023
Merged

[docs][joy] Update the TypeScript file to match the styles in the corresponding JavaScript file for adding more typography levels demo #38232

merged 2 commits into from
Jul 30, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jul 30, 2023 •
edited

After #38199, #36843 was merged without updating with the latest master branch. We need to match the TS demo with the newly updated JS demo file which has the style changes. This will fix the failing CI.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: Typography The React component. core Infrastructure work going on behind the scenes package: joy-ui Specific to @mui/joy labels Jul 30, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title update TS file for adding more levels typography [docs][joy] Update TS file for adding more levels in Typography page Jul 30, 2023
@mui-bot
Copy link

mui-bot commented Jul 30, 2023 •
edited

Netlify deploy preview

https://deploy-preview-38232--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b96f82f

@ZeeshanTamboli ZeeshanTamboli changed the title [docs][joy] Update TS file for adding more levels in Typography page [docs][joy] Update TS file of adding more levels demo to match JS file style Jul 30, 2023
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review July 30, 2023 04:54
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][joy] Update TS file of adding more levels demo to match JS file style [docs][joy] Update the TypeScript file to match the styles in the corresponding JavaScript file for adding more typography levels demo. Jul 30, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][joy] Update the TypeScript file to match the styles in the corresponding JavaScript file for adding more typography levels demo. [docs][joy] Update the TypeScript file to match the styles in the corresponding JavaScript file for adding more typography levels demo Jul 30, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 14a1838 into mui:master Jul 30, 2023
18 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the match-ts-demo-to-js-demo-joy-ui branch July 30, 2023 05:12
richbustos pushed a commit that referenced this pull request Aug 4, 2023
@ZeeshanTamboli
[docs][joy] Update TS file of adding more typography levels demo to m…
1be667d 
…atch the corresponding JS file's styles (#38232)
richbustos pushed a commit that referenced this pull request Aug 7, 2023
@ZeeshanTamboli
[docs][joy] Update TS file of adding more typography levels demo to m…
a12d5f8 
…atch the corresponding JS file's styles (#38232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: Typography The React component. core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZeeshanTamboli @mui-bot