[core] Use native Node's fetch instead of node-fetch package #38263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38263--material-ui.netlify.app/ Bundle size report |
michaldudak
added
dependencies
Janpot
approved these changes
Aug 1, 2023
|
I recall one issue with Danger not allowing its config file as ESM and blocking some of the dependencies, but I can't find it now. |
richbustos
pushed a commit
that referenced
this pull request
Aug 4, 2023
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to the native Node's implementation of
fetchas we're currently unable to update the node-fetch package (#31603). Plus, it's one dependency less to maintain.The Node fetch is still experimental, but we don't use it for anything mission-critical and we can afford it.