-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][Menu][base] Remove Unstyled
prefix from demos function names
#38270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
component: menu
This is the name of the generic UI component, not the React module!
package: base-ui
Specific to @mui/base
labels
Aug 1, 2023
Netlify deploy previewBundle size report |
Thanks for working on this, @sai6855! Could you also rename the demo directory to match the function names? |
@michaldudak updated directory name |
The directory is named MenuBasic, while the demos are named MenuSimple. |
michaldudak
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 3, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 3, 2023
michaldudak
changed the title
[Menu][base] Remove
[docs][Menu][base] Remove Aug 4, 2023
Unstyled
prefix from function namesUnstyled
prefix from demos' function names
richbustos
pushed a commit
that referenced
this pull request
Aug 4, 2023
sai6855
changed the title
[docs][Menu][base] Remove
[docs][Menu][base] Remove Aug 6, 2023
Unstyled
prefix from demos' function namesUnstyled
prefix from demos function names
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: menu
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
package: base-ui
Specific to @mui/base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened PR based on #37667 (comment)