Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Menu][base] Remove Unstyled prefix from demos function names #38270

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 1, 2023

Opened PR based on #37667 (comment)

@sai6855 sai6855 added component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Aug 1, 2023
@mui-bot
Copy link

mui-bot commented Aug 1, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ca3375c

@michaldudak
Copy link
Member

Thanks for working on this, @sai6855! Could you also rename the demo directory to match the function names?

@sai6855
Copy link
Contributor Author

sai6855 commented Aug 2, 2023

@michaldudak updated directory name

@michaldudak
Copy link
Member

The directory is named MenuBasic, while the demos are named MenuSimple.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 3, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 3, 2023
@michaldudak michaldudak added the docs Improvements or additions to the documentation label Aug 4, 2023
@michaldudak michaldudak changed the title [Menu][base] Remove Unstyled prefix from function names [docs][Menu][base] Remove Unstyled prefix from demos' function names Aug 4, 2023
@michaldudak michaldudak merged commit baaa347 into mui:master Aug 4, 2023
19 checks passed
@sai6855 sai6855 changed the title [docs][Menu][base] Remove Unstyled prefix from demos' function names [docs][Menu][base] Remove Unstyled prefix from demos function names Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants