-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Revise the theme typography page #38285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Improvements or additions to the documentation
package: joy-ui
Specific to @mui/joy
labels
Aug 2, 2023
danilo-leal
commented
Aug 2, 2023
docs/data/joy/customization/theme-typography/theme-typography.md
Outdated
Show resolved
Hide resolved
Netlify deploy previewBundle size report |
docs/data/joy/customization/theme-typography/theme-typography.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/theme-typography/theme-typography.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/theme-typography/theme-typography.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/theme-typography/theme-typography.md
Outdated
Show resolved
Hide resolved
docs/data/joy/customization/theme-typography/theme-typography.md
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Aug 4, 2023
@samuelsycamore & @siriwatknp let me know if this is good to go! |
samuelsycamore
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with this PR #38284 and browsing through the docs-feedback channel, I realized this page could use a revision, considering some stuff became outdated after the default theme polish PR merge!
https://deploy-preview-38285--material-ui.netlify.app/joy-ui/customization/theme-typography/