Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Box] Remove component from TypeMap (#38168)" #38356

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Revert "[Box] Remove component from TypeMap (#38168)" #38356

merged 2 commits into from
Aug 7, 2023

Conversation

michaldudak
Copy link
Member

This reverts commit de38693 (PR #38168).

It caused a breaking change in several use cases, described in #38274.

Closes #38274

@michaldudak michaldudak added package: system Specific to @mui/system component: Box The React component. regression A bug, but worse labels Aug 7, 2023
@mui-bot
Copy link

mui-bot commented Aug 7, 2023 •
edited

Netlify deploy preview

https://deploy-preview-38356--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6d9d06c

mnajdova
mnajdova reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would recommend adding the tests that made us to this revert. So that we catch them next time we iterate on the types.

@michaldudak
Copy link
Member Author

Good point. I added the test.

mnajdova
mnajdova approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's merge.

@mnajdova mnajdova merged commit 745bd53 into mui:master Aug 7, 2023
18 checks passed
@michaldudak michaldudak deleted the revert-38168 branch August 7, 2023 12:33
richbustos pushed a commit that referenced this pull request Aug 7, 2023
@michaldudak
Revert "[Box] Remove component from TypeMap (#38168)" (#38356)
c2481e8
@Methuselah96 Methuselah96 mentioned this pull request Aug 12, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: Box The React component. package: system Specific to @mui/system regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Box] Error when using component property in a styled Box component after upgrading to 5.14.3
3 participants
@michaldudak @mui-bot @mnajdova