Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Change the customization and how-to guides docs tree #38396

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Aug 9, 2023

Another one from the series of "browsing around and looking for improvement opportunities" 😬

One thing that was getting me confused browsing around the Joy UI docs is that, previously, we had under "How-to-guides" two relevant customization-related docs which left me wondering... why aren't they under "Customization"? From a visitor's perspective, I'd need to bounce back and forth between these groups, which doesn't sound good. Like, to customize the theme's color, I go to the "Colors" page under the "Theme" sub-category. But to create themeable components, I go to the "How-to guides".

Through doing this change, I realized the ones left were much more integrations-oriented (i.e. how to use Joy with X), so thought about just calling that folder/section "Integrations"!


Generally, it makes me wonder about the "How-to guides" folder and what would be appropriate to be there and not under the "Customization" sub-categories... Looking at the Material UI docs as a benchmark, I think some pages there do make sense to be under "How-to guides" (e.g. Server rendering; Routing; Minimizing bundle size; etc.) but also think many of them could actually be under "Customization" (e.g. Localization; Right-to-left, Responsive UI; etc.).

I'm curious about what y'all think! Happy to ditch this PR if it doesn't make any sense but it is looking better to me, at least! 😃 Also took the liberty to simplify the URLs as well as the page titles a bit, thought there was an opportunity to be a bit more concise.

The number of files changed looks a bit scary but it's more because I moved files here and there from folders ⎯ but haven't altered anything inside them.

Examples:

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Aug 9, 2023
@danilo-leal danilo-leal self-assigned this Aug 9, 2023
@zanivan
Copy link
Contributor

zanivan commented Aug 9, 2023

This way of organizing content is really helpful. It solves the problem with the 'how-to guides' category, which may not be clear to users since it can include different types of content like customization, integration, building blocks, or anything at all.

By putting all this content under the 'Customization' category, it makes it easier for users to find what they're looking for. Even though the content on some pages can still be considered a 'how-to guide,' these guides are better organized when under the right section, making users feel more assertive since they know that everything under the 'Customization' section is related to customizing things.

I would love to hear an opinion from a developer on this, though

@siriwatknp
Copy link
Member

siriwatknp commented Aug 22, 2023

I have had this problem since the beginning about the separation between "Customization" and "How-to-guide". What I categorized in the how-to is the content as steps for achieving a specific requirement.

I don't have any strong preferences and it would be nice if someone can come up with a rules/description of how we categorize the content. Happy to follow 😘

cc @samuelsycamore

@samuelsycamore
Copy link
Member

I think this is a big improvement!

What you've hit on here reminds me of a chapter from Docs For Developers where they outline different types of content. They distinguish between Conceptual docs (for explaining key concepts and features of your product) vs. Procedural docs (for demonstrating how to accomplish a specific goal by following a set of structured steps). In this case, it appears that our Customization docs are mainly conceptual, while the Integration docs are procedural, so it makes a lot more sense to organize them this way.

@samuelsycamore
Copy link
Member

Also, I don't think "How-to guides" makes much sense as a section in the Material UI docs either, because the definition of what qualities as one seems to be very vague. I think that the entire information architecture needs to be overhauled over there, but that's a whole other can of worms. 😅

@danilo-leal
Copy link
Contributor Author

Sweet, yeah! Thanks for the book reference! I'm not sure if I had ever come across that one, will check it out! @samuelsycamore @siriwatknp @zanivan let me know if y'all think this is a good enough structure to roll out or if there's anything we need to sort out before doing it?

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for taking care of this!

@danilo-leal danilo-leal merged commit 8f5ff61 into master Aug 24, 2023
24 checks passed
@danilo-leal danilo-leal deleted the joy-ui-customization-docs-map-change branch August 24, 2023 12:34
oliviertassinari added a commit that referenced this pull request Aug 31, 2023
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing redirections, e.g. https://mui.com/joy-ui/guides/next-js-app-router/ is a 404 now. Fixed in a71e6a0.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 2, 2023

ahrefs found more issues, fixed in #38761.

We should always have each older URL in _redirects and have no other search matches in the codebase.


@siriwatknp Do you want to receive the ahrefs weekly craw? I should delegate ensuring the SEO health stays at 100% to each team.

Screenshot 2023-09-02 at 23 31 19

https://app.ahrefs.com/site-audit

@siriwatknp
Copy link
Member

ahrefs found more issues, fixed in #38761.

We should always have each older URL in _redirects and have no other search matches in the codebase.

@siriwatknp Do you want to receive the ahrefs weekly craw? I should delegate ensuring the SEO health stays at 100% to each team.

Screenshot 2023-09-02 at 23 31 19 https://app.ahrefs.com/site-audit

Sure!

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
anon-phantom pushed a commit to anon-phantom/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

6 participants