[useButton][base] Fix tabIndex not being forwarded #38417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-38417--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
|
Codesandbox with fix: https://codesandbox.io/s/usebutton-tabindex-lost-pm839d |
michaldudak
approved these changes
Aug 11, 2023
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Diego Andai <diego@mui.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38368
The
tabIndexvalue was only taken into consideration for certain cases, so its value would be lost when not taken into consideration: https://codesandbox.io/s/usebutton-tabindex-lost-sd37h8?file=/Demo.tsxThis fix adds the
tabIndexvalue to thegetRootPropsreturn value initialization. This way, if explicitly provided, then it will be included ingetRootPropsreturn value. The previous behavior is maintained as thetabIndexis only added as a starting point.