[joy-ui][docs] Add FileUpload demo
#38420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewBundle size report |
sai6855
added
the
component: button
siriwatknp
reviewed
Aug 11, 2023
siriwatknp
reviewed
Aug 11, 2023
danilo-leal
reviewed
Aug 11, 2023
There was a problem hiding this comment.
This looks super good! One thing though, I think that this File upload + Link button should probably be under "Customization". The icon button makes sense to be outside of it as it's a different component entirely, but these two are mostly customizations. What do you think?
I agree, it makes more sense to place Link and file upload demos under customization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new demo which showcases how to turn
Buttoncomponent toinputcomponent with type asfile.preview: https://deploy-preview-38420--material-ui.netlify.app/joy-ui/react-button/#file-upload