[Tab] Change the ripple color to follow the spec #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
PR: Needs Review
design: material
| @@ -117,8 +119,7 @@ class Tab extends React.Component { | |||
| iconElement = React.cloneElement(icon, params); | |||
| } | |||
|
|
|||
| const rippleColor = styles.color; | |||
There was a problem hiding this comment.
That's undefined.
|
Noticed you're using all-caps for the If we're going to change the code style, shouldn't we do so consistently across library, and supported by an eslint rule? |
|
@mbrookes I have removed the change regarding the |
|
Looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec is at the very bottom of this page.