Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Fix key warning in SimpleDialog demo #38580

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[docs][material-ui] Fix key warning in SimpleDialog demo #38580

merged 1 commit into from
Aug 22, 2023
+4 −4

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 21, 2023 •
edited

Noticed while running the docs locally.

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Aug 21, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix key warning in console for SimpleDialog demo [docs][material-ui] Fix key warning for SimpleDialog demo Aug 21, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix key warning for SimpleDialog demo [docs][material-ui] Fix key warning in SimpleDialog demo Aug 21, 2023
@mui-bot
Copy link

mui-bot commented Aug 21, 2023 •
edited

Netlify deploy preview

https://deploy-preview-38580--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4d4f848

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 21, 2023 16:56
DiegoAndai
DiegoAndai approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ZeeshanTamboli ZeeshanTamboli merged commit d673fa8 into mui:master Aug 22, 2023
22 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the docs-dialog-key-warning branch August 22, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZeeshanTamboli @mui-bot @DiegoAndai