Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra][joy-ui] Polish the usage and CSS vars playgrounds #38600

Merged
merged 12 commits into from
Aug 23, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Aug 22, 2023

This PR adds a general polish to the introduction component playground demo and the CSS vars playground found across the Joy UI documentation. Some additional stuff was also made in order to have everything standardized & consistent:

  • Made their designs closer; given they have the same purpose, they should look similar.
  • Fixed the layout shift of the CSS vars number inputs. The reset button showed up after typing, which resulted in the increase/decrease button being pushed to the side, which was a bit frustrating.
  • Standardized their usage throughout docs + the "CSS variables playground" section title.

Examples:

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer package: joy-ui Specific to @mui/joy scope: docs-infra Specific to the docs-infra product labels Aug 22, 2023
@danilo-leal danilo-leal self-assigned this Aug 22, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2023
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2023
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement from the design POV! LGTM 🚀

@danilo-leal danilo-leal merged commit b843137 into mui:master Aug 23, 2023
18 checks passed
@danilo-leal danilo-leal deleted the polish-joy-ui-playgrounds branch August 23, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer package: joy-ui Specific to @mui/joy scope: docs-infra Specific to the docs-infra product
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants