Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base-ui]: Working With Tailwind Guide - revises example code to avoid import errors #38693

Merged

Conversation

christophermorin
Copy link
Contributor

Resolves #38692

If this is all O.K might I also suggest replacing the create-react-app use in this guide with Vite/Next.js? Rather outdated and a sad experience altogether on potato internet.

😃

@mui-bot
Copy link

mui-bot commented Aug 28, 2023

@christophermorin christophermorin changed the title docs: revises example code to avoid import errors [docs][base-ui]: Working With Tailwind Guide - revises example code to avoid import errors Aug 28, 2023
@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Aug 29, 2023
@brijeshb42
Copy link
Contributor

@michaldudak Can you take a look at the PR as well? LGTM.

@brijeshb42 brijeshb42 merged commit db09648 into mui:master Aug 29, 2023
19 of 20 checks passed
@michaldudak
Copy link
Member

@mj12albert, using Vite's not a bad idea (especially since even Tailwind recommends it over CRA). What do you think?

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][base-ui] Working With Tailwind guide - import conflicts in example code
5 participants